Skip to content

DAOS-18690 vos: handle DTX commit under space pressure#18141

Merged
gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-18690_4
May 14, 2026
Merged

DAOS-18690 vos: handle DTX commit under space pressure#18141
gnailzenh merged 1 commit into
masterfrom
Nasf-Fan/DAOS-18690_4

Conversation

@Nasf-Fan
Copy link
Copy Markdown
Contributor

@Nasf-Fan Nasf-Fan commented Apr 29, 2026

If we cannot normally allocate space to hold committed DTX table, then release some old DTX entries from some container in the same pool to hold new committed ones.

The patch also uses preallocated space for TX snapshots under the case of space pressure.

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Ticket title is 'Aurora daos_user: SCM single target ran out of space (min:0 B) and not able to finish GC. '
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-18690

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18690_4 branch from fb52edf to 141eacf Compare April 29, 2026 15:33
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 29, 2026

Test stage Unit Test bdev with memcheck completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18141/1/display/redirect

@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented Apr 29, 2026

Test stage Unit Test with memcheck completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18141/1/display/redirect

@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18690_4 branch from 141eacf to 5debe6c Compare April 29, 2026 15:38
Base automatically changed from Nasf-Fan/DAOS-18690_3 to master April 30, 2026 08:24
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18690_4 branch 2 times, most recently from cb42dd5 to d05080d Compare May 5, 2026 04:23
@Nasf-Fan Nasf-Fan mentioned this pull request May 5, 2026
Closed
6 tasks
@daosbuild3
Copy link
Copy Markdown
Collaborator

daosbuild3 commented May 5, 2026

Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18141/6/testReport/

@Nasf-Fan
DAOS-18690 vos: handle DTX commit under space pressure
51c08d0 
If we cannot normally allocate space to hold committed DTX table,
then release some old DTX entries from some container in the same
pool to hold new committed ones.

The patch also uses preallocated space for TX snapshots under the
case of space pressure.

Signed-off-by: Fan Yong <fan.yong@hpe.com>
@Nasf-Fan Nasf-Fan force-pushed the Nasf-Fan/DAOS-18690_4 branch from d05080d to 51c08d0 Compare May 6, 2026 03:18
@Nasf-Fan Nasf-Fan marked this pull request as ready for review May 7, 2026 01:16
@Nasf-Fan Nasf-Fan requested review from a team as code owners May 7, 2026 01:16
@Nasf-Fan Nasf-Fan requested review from gnailzenh, janekmi and knard38 May 7, 2026 01:18
knard38
knard38 approved these changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@knard38 knard38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my side the concerns that I have with the initial PR #18039 have been explained or fixed.

@Nasf-Fan
Copy link
Copy Markdown
Contributor Author

Nasf-Fan commented May 11, 2026 •
edited
Loading

Ping reviewers, thanks!

gnailzenh
gnailzenh approved these changes May 14, 2026
View reviewed changes
Comment thread src/vos/vos_dtx.c
}
stat->dtx_first_cmt_blob_time_up = dbd->dbd_committed_data[0].dce_cmt_time;
stat->dtx_first_cmt_blob_time_lo =
dbd->dbd_committed_data[dbd->dbd_count - 1].dce_cmt_time;
Copy link
Copy Markdown
Collaborator

@gnailzenh gnailzenh May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to have dbd_count=0 at here?

@gnailzenh gnailzenh merged commit b36dd7b into master May 14, 2026
39 checks passed
@gnailzenh gnailzenh deleted the Nasf-Fan/DAOS-18690_4 branch May 14, 2026 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnailzenh gnailzenh gnailzenh approved these changes

@knard38 knard38 knard38 approved these changes

@janekmi janekmi Awaiting requested review from janekmi

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nasf-Fan @daosbuild3 @gnailzenh @knard38